[wp-trac] [WordPress Trac] #37011: Don’t link custom logo if it’s displayed on the front page

WordPress Trac noreply at wordpress.org
Thu Apr 9 09:59:27 UTC 2020


#37011: Don’t link custom logo if it’s displayed on the front page
------------------------------+----------------------------
 Reporter:  FlorianBrinkmann  |       Owner:  joedolson
     Type:  enhancement       |      Status:  accepted
 Priority:  normal            |   Milestone:  5.5
Component:  Themes            |     Version:  4.6
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  accessibility
------------------------------+----------------------------

Comment (by SergeyBiryukov):

 Thanks for the patch! Just noting that checking both `is_home()` and
 `is_front_page()` seems redundant here. If a page is set as a front page
 and another one as a posts page, then the link should only be removed on
 the former, not on the latter.

 `is_front_page()` should be enough.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37011#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list