[wp-trac] [WordPress Trac] #49843: Twenty Nineteen: Fix editor style compatibility with Gutenberg 7.7 and above
WordPress Trac
noreply at wordpress.org
Wed Apr 8 16:20:43 UTC 2020
#49843: Twenty Nineteen: Fix editor style compatibility with Gutenberg 7.7 and
above
---------------------------+---------------------
Reporter: kjellr | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.5
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: needs-testing | Focuses:
---------------------------+---------------------
Comment (by kjellr):
> The floats aren't working well, though, and I think it's a regression of
a previous fix that brought us this rule:
Good catch. I think the `initial` approach is probably the simplest, and I
don't think it'll cause any issues. I'd rather avoid targeting `.is-root-
container`, just because I think targeting editor-specific classes has
made this file a lot more prone to breaking than it should be.
I've attached another patch. This one fixes that issue, but it does not
push the right-aligned items far off to the right of the text column. I
think that's fine for now, and it can be fixed in a followup PR. For some
reason, I also had to add left and right margins (I think the theme
previously relied on those to be provided by Gutenberg, but maybe they are
not now?). In any case, here's how that looks now:
[[Image(https://cldup.com/RJLFDl9lRj.png)]]
This patch also fixes wide alignments inside of full-width group blocks.
We should test (both in the current and plugin versions of Gutenberg) with
a variety of different layouts to verify that this works well now.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49843#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list