[wp-trac] [WordPress Trac] #47411: Build tools, WPCS: disable line ending check

WordPress Trac noreply at wordpress.org
Tue Apr 7 15:40:45 UTC 2020


#47411: Build tools, WPCS: disable line ending check
------------------------------+-------------------------------
 Reporter:  azaozz            |       Owner:  azaozz
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  5.5
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  coding-standards
------------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * keywords:  2nd-opinion => has-patch commit


Comment:

 Replying to [comment:17 SergeyBiryukov]:
 > It's still doesn't make sense to me that `phpcbf` converts all files to
 `\n` to enforce Unix EOLs on Windows, then SVN converts them back to
 `\r\n`, over and over again.

 These back-and-forth changes take a significant amount of time and are
 completely unnecessary.

 Since core has `svn:eol-style` set to `native` for most of the files, the
 `Generic.Files.LineEndings` sniff is simply not relevant for us and should
 be excluded entirely, as it's not a part of WPCS.

 See [attachment:"47411.2.diff"].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47411#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list