[wp-trac] [WordPress Trac] #49772: Support additional elements (table, ol, ul) in privacy policy guide new styling

[WordPress Trac]

#49772: Support additional elements (table, ol, ul) in privacy policy guide new
styling
-----------------------------+--------------------------------------
 Reporter:  garrett-eclipse  |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Privacy          |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:  ui, css, administration
-----------------------------+--------------------------------------
Description changed by garrett-eclipse:

Old description:

> With 5.4 ([r47147] / #44621) the privacy policy guide aesthetic was
> updated to introduce a white background on the suggested text. In the CSS
> this only applies to paragraph elements (`<p>`).
>
> Reviewing some other
> [https://wpdirectory.net/search/01E4VTZDVQY3Y4JJC8T51WGZHW plugin
> implementations] there is at minimum a need to also support `<ul>`,
> `<ol>`, and `<table>` elements.
> *I've only gone through the top 15 plugins from the link above so further
> investigation is in order.
>
> This primarily comes from a comment on the woocommerce PR
> [https://github.com/woocommerce/woocommerce/pull/25576#issuecomment-606632244
> here];
> > "Tested in WP 5.0 and 5.3.2, and in both cases the difference is that
> <p> sections inside the "Source: WooCommerce" section appear in italics
> after applying the changes; other elements (mostly <li>) appear
> unchanged. Is this the expected behavior?"
> While it refers to pre-5.4 the issue persists and gets worse in 5.4 in
> that it's not just italics but now padding and background which becomes
> jarring when it goes from a paragraph (styled) to a list (unstyled) and
> back to paragraph (styled).
>
> The white background in 5.4 is meant to denote the content being copied
> and as such should encompass these other elements;
> p - already does
> h# - shouldn't as the design excludes them
> hr - maybe
> ul - yes, used in plugins
> ([https://plugins.trac.wordpress.org/browser/woocommerce/trunk/includes
> /class-wc-privacy.php#L78 example])
> ol - yes, used in plugins ([https://plugins.trac.wordpress.org/browser
> /the-events-calendar/tags/5.0.3.1/src/admin-views/privacy.php#L33
> example])
> table - yes, used in plugins -
> ([https://plugins.trac.wordpress.org/browser/popup-
> maker/trunk/classes/Privacy.php#L72 example])
> div - potentially
> ... - Open to others as well.
>
> Also note the list items aren't denoted with bullet points in the current
> design. This makes them look like paragraphs and could be confusing.

New description:

 With 5.4 ([https://core.trac.wordpress.org/changeset/47147 r47147] /
 #44621) the privacy policy guide aesthetic was updated to introduce a
 white background on the suggested text. In the CSS this only applies to
 paragraph elements (`<p>`).

 Reviewing some other
 [https://wpdirectory.net/search/01E4VTZDVQY3Y4JJC8T51WGZHW plugin
 implementations] there is at minimum a need to also support `<ul>`,
 `<ol>`, and `<table>` elements.
 *I've only gone through the top 15 plugins from the link above so further
 investigation is in order.

 This primarily comes from a comment on the woocommerce PR
 [https://github.com/woocommerce/woocommerce/pull/25576#issuecomment-606632244
 here];
 > "Tested in WP 5.0 and 5.3.2, and in both cases the difference is that
 <p> sections inside the "Source: WooCommerce" section appear in italics
 after applying the changes; other elements (mostly <li>) appear unchanged.
 Is this the expected behavior?"
 While it refers to pre-5.4 the issue persists and gets worse in 5.4 in
 that it's not just italics but now padding and background which becomes
 jarring when it goes from a paragraph (styled) to a list (unstyled) and
 back to paragraph (styled).

 The white background in 5.4 is meant to denote the content being copied
 and as such should encompass these other elements;
 p - already does
 h# - shouldn't as the design excludes them
 hr - maybe
 ul - yes, used in plugins
 ([https://plugins.trac.wordpress.org/browser/woocommerce/trunk/includes
 /class-wc-privacy.php#L78 example])
 ol - yes, used in plugins ([https://plugins.trac.wordpress.org/browser
 /the-events-calendar/tags/5.0.3.1/src/admin-views/privacy.php#L33
 example])
 table - yes, used in plugins -
 ([https://plugins.trac.wordpress.org/browser/popup-
 maker/trunk/classes/Privacy.php#L72 example])
 div - potentially
 ... - Open to others as well.

 Also note the list items aren't denoted with bullet points in the current
 design. This makes them look like paragraphs and could be confusing.

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49772#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform