[wp-trac] [WordPress Trac] #48185: Remove old todo: Don't hard code activation link.
WordPress Trac
noreply at wordpress.org
Mon Sep 30 18:43:31 UTC 2019
#48185: Remove old todo: Don't hard code activation link.
-------------------------+-----------------------------
Reporter: david.binda | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: General | Version:
Severity: trivial | Keywords:
Focuses: |
-------------------------+-----------------------------
I've stumbled upon this [https://core.trac.wordpress.org/browser/trunk/src
/wp-includes/ms-functions.php?rev=46232#L962 TODO line in wp-includes/ms-
functins.php file]:
{{{#!php
// TODO: Don't hard code activation link.
}}}
It originates in [https://mu.trac.wordpress.org/changeset/543/ r 543 of
the mu repository]. By that time, the activation link
[https://mu.trac.wordpress.org/browser/trunk/wp-inst/wp-includes/wpmu-
functions.php?annotate=blame&rev=543#L1001 was really hardcoded]:
{{{#!php
$message = sprintf(__("To activate your blog, please click the following
link:\n\n%s\n\nAfter you activate, you will receive *another email* with
your login.\n\nAfter you activate, you can visit your blog
here:\n\n%s\n\nAnd you can login on the home
page:\n\nhttp://wordpress.com/"),
"http://wordpress.com/activate/$key", "http://$domain");
// TODO: Don't hard code activation link.
}}}
The current message is being composed using the `$activate_url`, which has
been introduced in [https://mu.trac.wordpress.org/changeset/550 r 550 of
the mu repository], I believe that the TODO comment is no longer needed.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48185>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list