[wp-trac] [WordPress Trac] #47115: Media Editor: Text overlaps or is clipped when text spacing or size is enlarged
WordPress Trac
noreply at wordpress.org
Mon Sep 30 14:44:25 UTC 2019
#47115: Media Editor: Text overlaps or is clipped when text spacing or size is
enlarged
-------------------------------------------------+-------------------------
Reporter: afercia | Owner: antpb
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.3
Component: Media | Version:
Severity: normal | Resolution:
Keywords: wpcampus-report has-screenshots | Focuses: ui,
needs-patch | accessibility
-------------------------------------------------+-------------------------
Comment (by sabernhardt):
==== Patch explanation: 47115.diff
'''Image Scale and Image Crop text inputs'''
1. The text inputs still have a fixed width, though it's increased from 50
to 80 pixels. (It could be somewhere in between; 90 is probably too wide.)
2. The Scale button is wrapped in a `<div>` so it moves below the inputs.
This requires a small top margin to make room for the focus outline. (It
also helps with translations such as Bulgarian at smaller text and input
sizes.) Another way would be setting the button to `display: block` and
adding the top margin there instead, but I thought wrapping it in a
container was a better option.
3. The original dimension values are wrapped in a `<span>` tag so both
width and height will stay on the same line.
'''Description buttons (and label)'''
1. The buttons were already trimmed by one pixel at the fixed height of
26px, so the patch switches that to `min-height`.
2. When the label had larger text, the stem (descender) of the lowercase p
was hidden behind the quicktags toolbar. This patch adds a small top
margin and increases the line-height (decimals are based on thirteenths).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47115#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list