[wp-trac] [WordPress Trac] #47138: Visible labelling only done via placeholder attribute
WordPress Trac
noreply at wordpress.org
Sat Sep 28 12:56:42 UTC 2019
#47138: Visible labelling only done via placeholder attribute
-------------------------------------------------+-------------------------
Reporter: anevins | Owner: audrasjb
Type: task (blessed) | Status: accepted
Priority: normal | Milestone: 5.3
Component: Media | Version:
Severity: minor | Resolution:
Keywords: has-screenshots wpcampus-report | Focuses: ui,
form-controls has-patch dev-feedback | accessibility
-------------------------------------------------+-------------------------
Changes (by audrasjb):
* keywords: has-screenshots needs-patch wpcampus-report form-controls =>
has-screenshots wpcampus-report form-controls has-patch dev-feedback
Comment:
In `47128.diff`, on both List and Grid media views:
- Remove placeholders for media search input
- Remove `screen-reader-text`class for media search label
- Add `media-search-input-label` class on media search label
- Add CSS styles to align label vertically
Works fine on my side. Would love to get some feedback, especially
concerning JS and CSS changes :-)
Cheers,
Jb
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47138#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list