[wp-trac] [WordPress Trac] #46747: Recent Comments widget can add duplicate ID to page

WordPress Trac noreply at wordpress.org
Fri Sep 27 20:34:16 UTC 2019


#46747: Recent Comments widget can add duplicate ID to page
---------------------------------------------------+-----------------------
 Reporter:  mbrailer                               |       Owner:  audrasjb
     Type:  defect (bug)                           |      Status:  assigned
 Priority:  normal                                 |   Milestone:  5.3
Component:  Widgets                                |     Version:  5.1
 Severity:  normal                                 |  Resolution:
 Keywords:  needs-dev-note has-patch dev-feedback  |     Focuses:
---------------------------------------------------+-----------------------
Changes (by audrasjb):

 * keywords:  needs-dev-note has-patch needs-refresh => needs-dev-note has-
     patch dev-feedback


Comment:

 @desrosj in `46747.2.diff` I added a staticvar to check if we are on the
 first occurence or not and to use #recentcomments ID or the widget ID.

 Example: see screenshot above.

 Works very fine on my side.
 Would be great if you could check that in terms of coding
 standards/docblock.

 Will update the dev note draft accordingly if the patch is good to go.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46747#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list