[wp-trac] [WordPress Trac] #41846: Avoid PHP notice in get_comment_reply_link() for null comment
WordPress Trac
noreply at wordpress.org
Fri Sep 27 17:54:41 UTC 2019
#41846: Avoid PHP notice in get_comment_reply_link() for null comment
---------------------------------------------+------------------------
Reporter: birgire | Owner: whyisjake
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 5.3
Component: Comments | Version: 2.7
Severity: normal | Resolution: fixed
Keywords: has-patch has-unit-tests commit | Focuses:
---------------------------------------------+------------------------
Comment (by johnbillion):
@birgire @whyisjake What bug does this fix? Returning early when there's
no global comment silences the error which, in my eyes, seems to be a
legitimate one. Calling this function in a context where there's no global
comment is incorrect.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41846#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list