[wp-trac] [WordPress Trac] #48126: Duplicate <h1> tags in twentynineteen

WordPress Trac noreply at wordpress.org
Thu Sep 26 18:01:17 UTC 2019

#48126: Duplicate <h1> tags in twentynineteen
 Reporter:  williampatton                        |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.3
Component:  Bundled Theme                        |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing reporter-    |     Focuses:
  feedback                                       |  accessibility
Changes (by adamsilverstein):

 * keywords:   => has-patch needs-testing reporter-feedback


 Aha! Figured it out. I was misreading the code, in twentynineteen we had
 `&&` instead of `||` in the PR.. as in `is_front_page() && is_home()`.

 What really want is to use the `h1` when either of these are true (the
 home page or the blog front page), eg `is_front_page() || is_home()`
 **except** when the home page is a static page (`! is_page()`) - the exact
 fix in

 I added this in [attachment:"48126.diff"]

 @sabernhardt / @williampatton can you please give that patch a test and
 see if you get a single h1 on your homepage?

Ticket URL: <https://core.trac.wordpress.org/ticket/48126#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list