[wp-trac] [WordPress Trac] #48111: Update usage of `multi_resize` to utilize new `wp_create_image_subsizes()` function

WordPress Trac noreply at wordpress.org
Thu Sep 26 17:30:02 UTC 2019


#48111: Update usage of `multi_resize` to utilize new `wp_create_image_subsizes()`
function
----------------------------+---------------------
 Reporter:  antpb           |       Owner:  (none)
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  5.3
Component:  Media           |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+---------------------
Changes (by azaozz):

 * keywords:  has-patch needs-testing => needs-patch


Comment:

 Replying to [comment:3 progremzion]:

 Unfortunately 48111.patch doesn't work as expected. We can switch to the
 new `wp_create_image_subsizes()` or `_wp_make_subsizes()` but that may
 also need handling of PHP fatal errors while processing images.

 Also it introduces a regression in `_wp_make_subsizes()`. It should be
 able to fall back to `$editor->multi_resize()` in case a plugin adds
 another class for processing images that is missing the new `make_subsize`
 method.

 (Also next time could you make diffs from the root WP dir, the parent of
 /src).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48111#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list