[wp-trac] [WordPress Trac] #41846: Avoid PHP notice in get_comment_reply_link() for null comment

WordPress Trac noreply at wordpress.org
Wed Sep 25 22:41:14 UTC 2019


#41846: Avoid PHP notice in get_comment_reply_link() for null comment
---------------------------------------------+---------------------
 Reporter:  birgire                          |       Owner:  (none)
     Type:  defect (bug)                     |      Status:  new
 Priority:  normal                           |   Milestone:  5.3
Component:  Comments                         |     Version:  2.7
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+---------------------

Comment (by whyisjake):

 When I run `phpunit --group comment` I am getting the following error.

 {{{
 1)
 Tests_Comment_GetCommentReplyLink::test_should_return_null_when_depth_less_than_max_depth_and_comment_null_and_no_current_global_comment
 TypeError: Argument 2 passed to PHPUnit\Framework\Assert::assertNull()
 must be of the type string, null given, called in
 /tests/phpunit/tests/comment/getCommentReplyLink.php on line 89

 /tests/phpunit/tests/comment/getCommentReplyLink.php:89
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41846#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list