[wp-trac] [WordPress Trac] #37536: Twenty Fifteen: Improve sticky sidebar logic.
WordPress Trac
noreply at wordpress.org
Wed Sep 25 21:37:20 UTC 2019
#37536: Twenty Fifteen: Improve sticky sidebar logic.
--------------------------------------------+-------------------------
Reporter: DvanKooten | Owner: whyisjake
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 5.3
Component: Bundled Theme | Version: 4.1
Severity: normal | Resolution: fixed
Keywords: bulk-reopened has-patch commit | Focuses: javascript
--------------------------------------------+-------------------------
Changes (by whyisjake):
* owner: (none) => whyisjake
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"46308" 46308]:
{{{
#!CommitTicketReference repository="" revision="46308"
Themes: Improve Twenty Fifteen sticky sidebar logic
The current logic in TwentyFifteen (#30366) for making the sidebar sticky
while still allowing to scroll through it when the sidebar height is
larger than the viewport height is flawed and massively overcomplicated.
This can be mitigated by removing the admin bar specific logic and leaving
most of the heavy lifting up to the browser.
Fixes #37536
Props DvanKooten, lukecavanagh, karmatosed, ianbelanger, davidbaumwald
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37536#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list