[wp-trac] [WordPress Trac] #46152: Add PHPCompatibility checks to test suite
WordPress Trac
noreply at wordpress.org
Tue Sep 24 21:31:04 UTC 2019
#46152: Add PHPCompatibility checks to test suite
-------------------------------------+-------------------------------
Reporter: desrosj | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 5.3
Component: Build/Test Tools | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses: coding-standards
-------------------------------------+-------------------------------
Comment (by jrf):
@desrosj Thanks for (yet again) updating the patches.
The only remark I have left is that it may be good to add `<!-- -->`
documentation to the newly added settings in the ruleset file, similar to
what is already in place for the other settings in the file, but that is
not a blocker for merging this.
Something along the lines of (rough notes):
{{{
<!-- Set the memory limit to 256M.
For most standard PHP configurations, this means the memory limit
will temporarily be raised.
Ref: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage
#specifying-phpini-settings -->
<ini name="memory_limit" value="256M"/>
<!-- Only scan PHP files. -->
<arg name="extensions" value="php"/>
<!-- Whenever possible, cache the scan results and re-use those for
unchanged files on the next scan. -->
<arg name="cache"/>
<!-- Strip the filepaths down to the relevant bit. -->
<arg name="basepath" value="./"/>
}}}
Other than that, all looks good & shiny to me 👍🏻
Note: I haven't tested the config locally, but I know you have and the
Travis run looks good.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46152#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list