[wp-trac] [WordPress Trac] #46371: Make sure in-page anchors are not hidden behind top bars
WordPress Trac
noreply at wordpress.org
Mon Sep 23 13:39:04 UTC 2019
#46371: Make sure in-page anchors are not hidden behind top bars
-------------------------------------------------+-------------------------
Reporter: afercia | Owner:
| SergeyBiryukov
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.3
Component: Toolbar | Version:
Severity: normal | Resolution:
Keywords: has-screenshots good-first-bug has- | Focuses: ui,
patch | accessibility
-------------------------------------------------+-------------------------
Comment (by afercia):
Testing a bit the patch I'm not fully convinced it's there :) The main
concern is that targeted elements will have an altered top margin and
padding. This value will likely alter the one provided by the team in use,
potentially introducing breakages.
To recap:
- the added spacing should be _additional_ to the one provided by the
active theme: not sure how to implement it but I'd recommend to explore a
new approach
- with a viewport width of max 600 pixels, the patch shouldn't do anything
- between 600 and 782 pixels the added spacing should be 46 pixels
- above 782, it should be 32 pixels
- maybe consider to use just `.entry-content :target` to set the rule to
any anchor, also the ones manually added within the content
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46371#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list