[wp-trac] [WordPress Trac] #42888: Add a "Show" button next to password fields on mobile

[WordPress Trac]

#42888: Add a "Show" button next to password fields on mobile
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  afercia
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.3
Component:  Login and Registration   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  accessibility,
  screenshots has-ux-feedback        |  javascript
  commit                             |
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  has-patch has-screenshots has-ux-feedback needs-refresh =>
     has-patch has-screenshots has-ux-feedback commit


Comment:

 [attachment:"42888.5.diff"] refreshes the patch. Differences:
 - the `no-js` class was recently added in [46192]
 - improves vertical alignment of the button icon by 1 pixel

 Seems to me it's a good and self-contained improvement. I'd like to commit
 this for 5.3 Beta 1 so it can get more eyes and feedback.

 @anevins you're right that icon-only controls are a known accessibility
 anti-pattern and visible text should be provided instead. This would
 require new design. Considering that also the buttons in the User edit /
 new pages display only an icon in the responsive view, I'd tend to think
 this should be addressed holistically for all these buttons. The next
 release cycle would be a good opportunity to audit these controls and
 improve them.

 For now, I'd propose to get this change in core as it's an improvement.
 The base functionality (entering a password) is accessible to everyone. Te
 visibility toggle can be improved but that's an additional feature that
 doesn't prevent the use of the password field. Also, the aria-labels
 associated to the button are simple enough and pretty intuitive:
 - Show password
 - Hide password

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42888#comment:51>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform