[wp-trac] [WordPress Trac] #36998: wp_sanitize_redirect() strips spaces out of URLs instead of encoding them

WordPress Trac noreply at wordpress.org
Sun Sep 22 18:46:17 UTC 2019


#36998: wp_sanitize_redirect() strips spaces out of URLs instead of encoding them
--------------------------------------+-----------------------------
 Reporter:  hlashbrooke               |       Owner:  SergeyBiryukov
     Type:  defect (bug)              |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.3
Component:  Formatting                |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------------
Changes (by azaozz):

 * keywords:  has-patch => has-patch has-unit-tests


Comment:

 36998.1.diff looks good. As @dd32 mentions above I'm more concerned that
 it means the URL passed to the redirect [#comment:2 is not well-formed].
 As the function already url-encodes multibyte characters, seems it should
 encode spaces as well.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/36998#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list