[wp-trac] [WordPress Trac] #45307: Can't undo auto-embeds

[WordPress Trac]

#45307: Can't undo auto-embeds
--------------------------+---------------------
 Reporter:  afercia       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  5.3
Component:  TinyMCE       |     Version:  4.8
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |     Focuses:
--------------------------+---------------------
Changes (by azaozz):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:9 afercia]:
 > A single auto-embed followed by an Undo seems to work. However, then
 going back/forth through Undo/Redo multiple times, things get a bit weird.

 My guess is that when going back and forth through undo and redo fast,
 sometimes the embedding/wpview doesn't run fully. It is quite complex and
 has many "built-in" delays and timeouts. When that happens is creates a
 partial undo "level" which introduces the edge case.

 As far as I see doing undo and redo "at a normal pace", mixed with other
 editing actions not just adding wpviews works as expected.

 Thinking this is "as good as it gets" for now. To try to remove the
 remaining edge case we'll need to refactor how wpview works. That's lots
 of changes and out of scope here :)

 Closing this s fixed for now. Lets make a new ticket with exact steps to
 consistently reproduce if it still happens a lot.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45307#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform