[wp-trac] [WordPress Trac] #48093: get_comment_count() should return an integer for all counts of all statuses
WordPress Trac
noreply at wordpress.org
Sat Sep 21 16:30:37 UTC 2019
#48093: get_comment_count() should return an integer for all counts of all statuses
-------------------------------------------------+-------------------------
Reporter: johnbillion | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting
| Review
Component: Comments | Version: 2.0
Severity: normal | Resolution:
Keywords: needs-unit-tests good-first-bug | Focuses:
has-patch |
-------------------------------------------------+-------------------------
Changes (by progremzion):
* keywords: needs-patch needs-unit-tests good-first-bug => needs-unit-
tests good-first-bug has-patch
Comment:
Hi @johnbillion
I have fixed the issue. Can you please review? I am new to core
contribution, so please do let me know if something is missing.
We don't need to update the `Tests_Get_Comment_Count()` class as by
updating the `get_comment_count` function's return value will resolve
that.
Thanks!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48093#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list