[wp-trac] [WordPress Trac] #48086: Add required extensions and libraries to composer.json
WordPress Trac
noreply at wordpress.org
Sat Sep 21 00:54:03 UTC 2019
#48086: Add required extensions and libraries to composer.json
-----------------------------------+-------------------------------------
Reporter: dingo_d | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Build/Test Tools | Version: 5.2.3
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion | Focuses: docs, coding-standards
-----------------------------------+-------------------------------------
Comment (by jrf):
Hi @dingo_d Yet another great step towards the future!
I've reviewed your patch and have two remarks:
1. Please undo the update to the `PHP_CodeSniffer` package in the
`composer.lock` file. There is an issue with a particular sniff which is
why this update hadn't been done yet - see #47632 for more details.
2. IIRC adding the `lib-...` requirements is only useful when you actually
add versions to them. Otherwise, set the `ext-...` with `*` instead (for
those extensions which are not part of the PHP core).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48086#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list