[wp-trac] [WordPress Trac] #47131: Cursor suggests functionality even when functionality is not present

[WordPress Trac]

#47131: Cursor suggests functionality even when functionality is not present
-------------------------------------+-------------------------------------
 Reporter:  anevins                  |       Owner:  antpb
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.3
Component:  Media                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots          |     Focuses:  ui, accessibility,
  wpcampus-report has-patch          |  javascript
-------------------------------------+-------------------------------------
Changes (by antpb):

 * keywords:  has-screenshots wpcampus-report has-patch needs-refresh =>
     has-screenshots wpcampus-report has-patch


Comment:

 Just reporting that my testing confirms that the patch still fixes the
 issue and that also the `dashboard.js` instances of sortable are
 respecting the width condition of the newly introduced
 `maybeDisableSortables` function and do not allow movement when in the one
 column width less than 782.

 For visibility, here is the logic that controls if sortable is applied
 based on width and column prefs && number of boxes:

 {{{
                         if (
                                 ( width <= 782 ) ||
                                 ( 1 >= $sortables.find( 'h2:visible'
 ).length && jQuery( '.columns-prefs-1 input' ).prop( 'checked' ) )
                         ) {
                                 this.disableSortables();
                         } else {
                                 this.enableSortables();
                         }

 }}}


 I have one more instance to verify in `postbox.js` Will hopefully have
 some good news soon, but this is looking super close to being ready for a
 final review.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47131#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform