[wp-trac] [WordPress Trac] #45954: Add a extra_tablenav() method to WP_MS_Sites_List_Table
WordPress Trac
noreply at wordpress.org
Fri Sep 20 19:11:33 UTC 2019
#45954: Add a extra_tablenav() method to WP_MS_Sites_List_Table
-------------------------------------+-------------------------------------
Reporter: pbiron | Owner: desrosj
Type: feature request | Status: reviewing
Priority: normal | Milestone: 5.3
Component: Networks and Sites | Version: 5.1
Severity: normal | Resolution:
Keywords: has-screenshots has- | Focuses: administration,
patch | multisite
-------------------------------------+-------------------------------------
Comment (by desrosj):
[attachment:"45954.diff"] has a few changes:
- Coding standards fixes.
- Removes `()` for the exit call (there should be a separate ticket to
remove all of these since it is a language construct and does not require
them)
I also looked at how the other list tables handle these requests. Between
`edit.php`, `users.php`, and `edit-comments.php`, there are some
inconsistencies.
- Some use `$_GET`, some use $_REQUEST` for the conditional.
- Some use `$_REQUEST` some use `$_SERVER` for building the redirect URL.
- Both use `wp_redirect()` instead of `wp_safe_redirect()`.
I've updated the patch to be more consistent with these, even though there
are some differences.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45954#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list