[wp-trac] [WordPress Trac] #45928: Twenty Nineteen: Add a filter to the $primary_color variable

[WordPress Trac]

#45928: Twenty Nineteen: Add a filter to the $primary_color variable
-------------------------------------------------+-------------------------
 Reporter:  allancole                            |       Owner:  desrosj
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.3
Component:  Bundled Theme                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-       |     Focuses:
  refresh                                        |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch needs-testing => has-patch needs-testing needs-
               refresh


Comment:

 I have some questions on this.

 If we are introducing functions to get the default hue, saturation,
 lightness, etc., is there a need for the filters being introduced in the
 `functions.php` file? `$default_hue` is being set by calling one of those
 `*_get_default_*` functions, but the saturation, lightness, and lightness
 hover are not.

 Any new filter being introduces should also be accompanied by
 [https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/#4-hooks-actions-and-filters a proper
 docblock].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45928#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform