[wp-trac] [WordPress Trac] #39776: add priority argument to add_submenu_page() function

[WordPress Trac]

#39776: add priority argument to add_submenu_page() function
-------------------------------------------------+-------------------------
 Reporter:  alexvorn2                            |       Owner:  welcher
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.3
Component:  Menus                                |     Version:  4.7.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback needs-        |     Focuses:
  testing has-unit-tests                         |  administration
-------------------------------------------------+-------------------------

Comment (by birgire):

 @adamsilverstein Good idea to add tests for the other touched functions.
 Thanks for adding those.

 The tests runs successfully on my install.

 Just a minor thing, I justed noticed in [attachment:"39776.14.diff"]:

 {{{
 // Reset menus.
 $submenu = [];
 $menu    = [];
 }}}

 I think the {{{array()}}} form is now preferred regarding CS.

 [attachment:"39776-15.diff"] expands on the PHPDocs and suggests a way to
 make sure no test code runs after the assertions.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39776#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform