[wp-trac] [WordPress Trac] #48078: Some WP_XXX_Query::query() methods produce incorrect results when called in a loop

WordPress Trac noreply at wordpress.org
Thu Sep 19 19:05:18 UTC 2019


#48078: Some WP_XXX_Query::query() methods produce incorrect results when called in
a loop
--------------------------+------------------------------
 Reporter:  pbiron        |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |     Focuses:  multisite
--------------------------+------------------------------

Comment (by pbiron):

 Replying to [comment:1 johnjamesjacoby]:
 > From having worked closely with `WP_Query` and `WP_User_Query` more than
 any of the others, I can tell you that I wrongly expected the `query()`
 method in `WP_Site_Query` to work this way when used repeatedly.

 I whole heartedly agree that consistency across similar classes/methods is
 a big advantage for developers (can't tell you how much time I've wasted
 over the years when dealing with a method in class X that works
 differently that a seemingly identical one on another class) but wanted to
 start this off as a ''discussion about expected behavior'' and reach
 consensus on that before jumping in with a patch right off the bat.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48078#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list