[wp-trac] [WordPress Trac] #36824: do_all_pings function queries all posts
WordPress Trac
noreply at wordpress.org
Thu Sep 19 11:45:26 UTC 2019
#36824: do_all_pings function queries all posts
--------------------------------------+---------------------------
Reporter: spacedmonkey | Owner: boonebgorges
Type: enhancement | Status: closed
Priority: normal | Milestone: 5.3
Component: Pings/Trackbacks | Version: 2.1
Severity: normal | Resolution: fixed
Keywords: has-patch has-unit-tests | Focuses: performance
--------------------------------------+---------------------------
Changes (by SergeyBiryukov):
* status: reopened => closed
* resolution: => fixed
Comment:
In [changeset:"46182" 46182]:
{{{
#!CommitTicketReference repository="" revision="46182"
Tests: Replace `join()` with `implode()` in `do_enclose()` tests
introduced in [46175], and ensure the arguments passed are in the correct
order.
The `implode()` function accepts two parameters, `$glue` and `$pieces`.
For historical reasons, these parameters have been accepted in any order,
though it was recommended that the documented order of `$glue, $pieces` be
used. It is also generally considered best practice to use the canonical
function rather than an alias.
Starting in PHP 7.4, specifying the parameters in the reverse order will
trigger a deprecation notice with the plan to remove this tolerance in PHP
8.0.
Props jrf.
Fixes #36824. See #47746.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36824#comment:64>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list