[wp-trac] [WordPress Trac] #48028: Media Library 'featured image' dialogue missing link text that describes 'opens in new tab'.
WordPress Trac
noreply at wordpress.org
Thu Sep 19 09:35:24 UTC 2019
#48028: Media Library 'featured image' dialogue missing link text that describes
'opens in new tab'.
-------------------------------------------------+-------------------------
Reporter: anevins | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.3
Component: Media | Version:
Severity: normal | Resolution:
Keywords: has-screenshots wpcampus-report | Focuses:
has-patch | accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):
* keywords: has-screenshots wpcampus-report good-first-bug has-patch =>
has-screenshots wpcampus-report has-patch
Comment:
Looking a bit more in depth into this issue, it appears it's a bit more
complicated than expected.
In the Classic Editor the "Edit Image" link doesn't open a new tab. Even
if it does have a `target="_blank"` attribute, the default action is
prevented and the media modal updates its content to display the image
editor. This is intended behavior. See
https://core.trac.wordpress.org/browser/trunk/src/js/media/views/attachment/details.js?rev=45561&marks=189-199#L180
Instead, in Gutenberg and in the Customizer it opens a new tab. This
happens because `editState` is undefined and I'm not sure it's the
intended behavior to start with.
Would anyone from the Media or Editor team clarify if there's any reason
why the Image Editor should open in a new tab in the context of Gutenberg
(and the Customizer)?
Pinging some of the related components maintainers: @antpb @mikeschroder
@azaozz @iseulde
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48028#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list