[wp-trac] [WordPress Trac] #46895: Personal Data Export Report: A way to display the group count

[WordPress Trac]

#46895: Personal Data Export Report: A way to display the group count
-------------------------------------------------+-------------------------
 Reporter:  birgire                              |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.3
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch has-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by pputzer):

 Replying to [comment:9 garrett-eclipse]:
 > I also agree with your statement "there's no need to display the group
 count for a single item" and it begs the question if the group_count
 (previously group_display_count) boolean is even necessary here. Can we
 just not display the count if more than one for all groups. I don't
 believe there's a case where a group has multiple items and the count
 wouldn't be useful. And by requiring a boolean set would mean a dev-note
 would be required and the third-party tools that use the exporter will
 need to be aware of the boolean and update their implementation to utilize
 it, by simply adding count when >1 all third-party tools automatically are
 accounted for.

 I think it might be useful to see at a glance which groups could have more
 items (but don't), so if we decide to go with the explicit enabling
 property, I think "Comments (1)" should be displayed.

 As for the other approach, automatically adding the group count if item
 count > 1 sounds very elegant architecturally. I was hesitant for a moment
 for any BC issues, but since this would only affect the HTML output, it
 should not have an effect on plugins that add to existing Core groups in
 their data exporters.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46895#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform