[wp-trac] [WordPress Trac] #44133: Should the Data Export indicate when we have no information on the user

[WordPress Trac]

#44133: Should the Data Export indicate when we have no information on the user
-------------------------------------------------+-------------------------
 Reporter:  garrett-eclipse                      |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  5.3
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:
  testing 2nd-opinion                            |  administration
-------------------------------------------------+-------------------------

Comment (by pputzer):

 Replying to [comment:52 garrett-eclipse]:
 > Hi @xkon thanks for the refresh here. This worked nicely.
 >
 > I uploaded 44133.10.diff to address some minor items (spelling, grammar
 and missed the ##LINK## phpdoc reference on the second filter) and
 milestone it for 5.3.0.

 Minor issue: There are several instances of "@since 5.2.0" that need to be
 changed to "@since 5.3.0".

 >It also updates the unit tests to account for the additional parameters.
 Which makes me wonder if we should make the extra two params optional with
 the `= false` for backward compatibility as I added a check if $request is
 false already. Thoughts?

 I'd say add the default parameters, otherwise line 2171 (`if ( ! $request
 )`) is meaningless. If so, I think the parameter should be type hinted to
 `WP_User_Request` and any check for `false` returned by
 `wp_get_user_request_data ` would have to occur on the caller side.

 > I'm a little torn with the introduction of a second filter for almost
 the same email, especially since the boolean differentiating the two is
 supplied as an argument. I understand the email content differs by the
 single new line so there's that to take into account as well.

 With the added parameter, I also don't think the separate filter would be
 necessary, but in theory this could be a BC break. However, if there's a
 separate hook, I don't think the parameter needs to be there for the
 filter.

 Also, I don't think "You may download your personal data by [...]" is a
 good wording when we just said there's no personal data. Maybe something
 like "You may download a confirmation document by ..." would be better?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44133#comment:57>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform