[wp-trac] [WordPress Trac] #48011: Having issue with navigation menu not updated

WordPress Trac noreply at wordpress.org
Tue Sep 17 23:39:14 UTC 2019


#48011: Having issue with navigation menu not updated
-------------------------------------------------+-------------------------
 Reporter:  zaheerahmad                          |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Menus                                |     Version:  5.2.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots needs-testing has-   |     Focuses:
  patch                                          |
-------------------------------------------------+-------------------------
Changes (by achyuthajoy):

 * keywords:  has-screenshots needs-testing needs-patch => has-screenshots
     needs-testing has-patch


Comment:

 Thanks for taking a look @desrosj. It seems the diff file I added was
 incorrect. It changes should be in reverse. I'm adding a new patch file.

 > Thanks for this ticket, @zaheerahmad, and thanks for investigating,
 @achyuthajoy!
 >
 > I am able to reproduce the issue described with the steps that were
 outlined.
 >
 > However, it seems that [attachment:"trac-48011.diff"] is not applying
 for me. Looking at `src/wp-includes/nav-menu.php`
 ([https://core.trac.wordpress.org/browser/tags/5.2.3/src/wp-includes/nav-
 menu.php#L487 source]), I actually don't see the line being replaced in
 the patch, and the suggested change is already present. Can you take
 another look @zaheerahmad? Some unit tests showing the problem may also be
 helpful.
 >
 > I am going to put this in the Future Release milestone. But, once a
 patch is ready and tested, this can be moved into a numbered milestone.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48011#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list