[wp-trac] [WordPress Trac] #47746: PHP 7.4 compatibility fix / implode argument order

[WordPress Trac]

#47746: PHP 7.4 compatibility fix / implode argument order
------------------------------------+-------------------------------
 Reporter:  jrf                     |       Owner:  desrosj
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  5.3
Component:  General                 |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch php74 commit  |     Focuses:  coding-standards
------------------------------------+-------------------------------

Comment (by desrosj):

 In [changeset:"46155" 46155]:
 {{{
 #!CommitTicketReference repository="" revision="46155"
 General: Ensure the arguments passed to `implode()` are in the correct
 order.

 The `implode()` function accepts two. parameters, `$glue` and `$pieces`.
 For historical reasons, these parameters have been accepted in any order,
 though it was recommended that the documented order of `$glue, $pieces` be
 used.

 Starting in PHP 7.4, specifying the parameters in the reverse order will
 trigger a deprecation notice with the plan to remove this tolerance in PHP
 8.0.

 This change fixes the occurrences of reversed arguments in Core with the
 exception of those contained in included external libraries. These will be
 handled separately.

 Props jrf, jorbin.
 See #47746.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47746#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform