[wp-trac] [WordPress Trac] #45954: Add a extra_tablenav() method to WP_MS_Sites_List_Table

WordPress Trac noreply at wordpress.org
Mon Sep 16 22:40:35 UTC 2019


#45954: Add a extra_tablenav() method to WP_MS_Sites_List_Table
-------------------------------------+-------------------------------------
 Reporter:  pbiron                   |       Owner:  (none)
     Type:  feature request          |      Status:  new
 Priority:  normal                   |   Milestone:  5.3
Component:  Networks and Sites       |     Version:  5.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  administration,
  patch                              |  multisite
-------------------------------------+-------------------------------------

Comment (by pbiron):

 Replying to [comment:8 pbiron]:
 > I was planning on adding some unit tests, but discovered there are no
 tests for the equivalent filters provided by other list tables so I didn't
 bother with any here.
 >
 > The only tests I can find related to `extra_tablenav()` are for
 `WP_Posts_List_Table` (e.g.,
 >
 `Tests_Admin_includesListTable::test_filter_button_should_not_be_shown_if_there_are_no_posts()`,
 etc).  I could add a test similar to those that checks that the "Filter"
 button is present if nothing hooks into the new filters, but I don't think
 that is really necessary.

 With 5.3 beta 1 due in 1 week (Sep 23), can we get this committed?

 Should I add 1 or more unit tests similar to the ones for
 `WP_Posts_List_Table`?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45954#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list