[wp-trac] [WordPress Trac] #47678: Modernize/simplify current_user_can()

[WordPress Trac]

#47678: Modernize/simplify current_user_can()
-------------------------------------+-------------------------------------
 Reporter:  jrf                      |       Owner:  pento
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.3
Component:  Role/Capability          |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-unit-      |     Focuses:  performance, coding-
  tests commit needs-dev-note        |  standards
-------------------------------------+-------------------------------------

Comment (by jrf):

 @SergeyBiryukov Thanks for committing those patches <3

 > I think it's still preferable to show a proper error message on PHP <
 5.6, at least until a switch to PHP 7.x is made.

 I agree, though to be honest, this would indicate that the PHP version
 check is done too late in the process flow, rather than that this patch is
 invalid.

 All the same, let's leave that for later.

 > 1. Could you refresh the patch without changing the function signature
 for now?

 Done. See the newly uploaded patch. Passing build for the patch: https
 ://travis-ci.com/WordPress/wordpress-develop/builds/127739735

 > 2. Could you create a new ticket for reconsidering the revert of
 [45624]?

 Would you mind explaining why this should be moved to a new ticket ?

 I'd personally rather we keep it in this ticket as comments 23 up to 29
 contain a detailed analysis of the impact, which would otherwise need to
 be re-iterated completely in a new ticket.

 It has already been established that the changes made via this ticket need
 a dev-note, as the function signature of a number of methods has changed,
 `Walker:walk()` is just one of those methods and should IMO not have
 special status just because the VIP platform overloads the method.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47678#comment:59>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform