[wp-trac] [WordPress Trac] #47478: Update Backbone.js to 1.4.0

WordPress Trac noreply at wordpress.org
Sat Sep 14 01:29:57 UTC 2019


#47478: Update Backbone.js to 1.4.0
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:
                                                 |  priyankkpatel
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.3
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  early good-first-bug has-patch       |     Focuses:
  needs-testing needs-refresh                    |
-------------------------------------------------+-------------------------

Comment (by pierlo):

 Took some time out and managed to solve this. The `_listeners` object was
 being applied to the `states` Collection in the StateMachine, instead of
 the StateMachine itself. This is because of a change in Backbone v1.4.0
 which applies listeners to the object's public `on` method (in this case
 the StateMachine maps events and triggers to the `states` object).

 (https://core.trac.wordpress.org/attachment/ticket/47478/47478.3.patch
 47478.3.patch) fixes this by passing the `states` object instead of the
 StateMachine. I also refactored StateMachine to remove some dead code.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47478#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list