[wp-trac] [WordPress Trac] #46303: Update wp_privacy_send_personal_data_export_email to provide the same filters as _wp_privacy_send_erasure_fulfillment_notification

WordPress Trac noreply at wordpress.org
Fri Sep 13 17:28:25 UTC 2019


#46303: Update wp_privacy_send_personal_data_export_email to provide the same
filters as _wp_privacy_send_erasure_fulfillment_notification
-------------------------------------------------+-------------------------
 Reporter:  garrett-eclipse                      |       Owner:  garrett-
                                                 |  eclipse
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.3
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests needs-dev-note                           |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch needs-testing needs-unit-tests => has-patch needs-
     testing has-unit-tests needs-dev-note


Comment:

 Hi @rconde thanks for the ping, I'm hoping to land this in 5.3.0.

 I've refreshed the patch in
 [https://core.trac.wordpress.org/attachment/ticket/46303/46303.4.diff
 46303.4.diff] so it applies cleanly now that everything lives in privacy-
 tools.php. Updated version numbers and addressed some CS issues.

 Also introduced unit tests;
 -
 Tests_Privacy_WpPrivacySendPersonalDataExportEmail::`test_email_address_of_recipient_should_be_filterable`
 - Tests new `wp_privacy_personal_data_email_to` filter.
 -
 Tests_Privacy_WpPrivacySendPersonalDataExportEmail::`test_email_subject_should_be_filterable`
 - Tests new `wp_privacy_personal_data_email_subject` filter.
 -
 Tests_Privacy_WpPrivacySendPersonalDataExportEmail::`test_email_content_should_be_filterable_using_email_data`
 - Tests addition of `$email_data` to the
 `wp_privacy_personal_data_email_content` filter.
 * These are all found in the `wpPrivacySendPersonalDataExportEmail.php`
 test suite.

 @birgire would you mind reviewing my unit tests and review/test the patch
 in general.

 @rconde / @thakkarhardik would appreciate any review/testing you're able
 to do on the patch.

 Thank you
 P.S. Marking with `needs-dev-note` as this patch introduces two new
 filters (`wp_privacy_personal_data_email_to` &
 `wp_privacy_personal_data_email_subject`) and adds `$email_data` to the
 `wp_privacy_personal_data_email_content` filter.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46303#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list