[wp-trac] [WordPress Trac] #39776: add priority argument to add_submenu_page() function
WordPress Trac
noreply at wordpress.org
Wed Sep 11 11:34:47 UTC 2019
#39776: add priority argument to add_submenu_page() function
-------------------------------------------------+-------------------------
Reporter: alexvorn2 | Owner: welcher
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.3
Component: Menus | Version: 4.7.2
Severity: normal | Resolution:
Keywords: has-patch dev-feedback needs- | Focuses:
testing has-unit-tests | administration
-------------------------------------------------+-------------------------
Comment (by birgire):
Thanks for the tests @welcher
just few minor suggestions after quick skimming of
[attachment:"39776.7.diff"]:
- Add {{{@ticket 39776}}} on test method
- Avoid running code after assertions, it will not run if assertions
fails.
- e.g. add {{{@since 5.3.0}}} on helper test methods?
- Missing end of line dot, for some inline comments.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39776#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list