[wp-trac] [WordPress Trac] #39776: add priority argument to add_submenu_page() function
WordPress Trac
noreply at wordpress.org
Mon Sep 9 14:49:36 UTC 2019
#39776: add priority argument to add_submenu_page() function
-------------------------------------------------+-------------------------
Reporter: alexvorn2 | Owner: welcher
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.3
Component: Menus | Version: 4.7.2
Severity: normal | Resolution:
Keywords: has-patch dev-feedback needs- | Focuses:
testing needs-unit-tests | administration
-------------------------------------------------+-------------------------
Changes (by adamsilverstein):
* keywords: has-patch dev-feedback early => has-patch dev-feedback needs-
testing needs-unit-tests
Comment:
@welcher Thanks for continuing to work on this.
It would be great to add some tests to verify this works as expected. I'm
a little concerned in particular with the position slicing logic and
possible edge cases, for example if the passed position exceeds the
submenus array length. Unit tests would help confirm this always works as
written. We can hopefully build off existing tests.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39776#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list