[wp-trac] [WordPress Trac] #46830: When menu item removed form Customizer menu uncheck it's source item

[WordPress Trac]

#46830: When menu item removed form Customizer menu uncheck it's source item
---------------------------------------+-----------------------
 Reporter:  garrett-eclipse            |       Owner:  audrasjb
     Type:  defect (bug)               |      Status:  accepted
 Priority:  normal                     |   Milestone:  5.3
Component:  Menus                      |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui
---------------------------------------+-----------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch => has-patch has-screenshots


Comment:

 Thanks @donmhico this worked really nicely, testing both Posts and Pages
 the check indicator reverts to the + add icon once all items are removed
 as desired.

 Reviewing the code everything looked very well written thank you. In php
 unit tests I've seen ticket references as `@ticket XXXXX` but I'm not sure
 if that's also the standard with JS (referring to your `@see` reference).

 @audrasjb would you mind taking a final review this works nicely and
 applies cleanly.

 P.S. While testing I found the check icon is lost if you click 'Add Items'
 to open/close the drawer. I've opened
 [https://core.trac.wordpress.org/ticket/47990 47990] to look into keep
 that persistent.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46830#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform