[wp-trac] [WordPress Trac] #47954: Create a sanity check for siteurl and home changes

[WordPress Trac]

#47954: Create a sanity check for siteurl and home changes
----------------------------+---------------------------------
 Reporter:  Otto42          |       Owner:  (none)
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui, administration
----------------------------+---------------------------------

Comment (by donmhico):

 Thanks for the feedback @Clorith. The latest patch,
 [https://core.trac.wordpress.org/attachment/ticket/47954/47954.2.diff
 47954.2.diff], applies the changes you recommended. The expiry time is now
 using `30 * MINUTE_IN_SECONDS` and also filterable. See
 https://github.com/donmhico/wordpress-
 develop/commit/19617ea6d50573919d4b775072fcb8e8a170e3e8

 Regarding where it is hooked. Correct me if i'm wrong, but
 `registered_taxonomy` is the earliest possible action I can hook it to
 where the `pluggable.php` is already loaded. The restore function uses
 `wp_redirect()` which is declared in `pluggable.php`, hence if I want to
 hook it in `muplugins_loaded`, I need to either load `pluggable.php` when
 needed to or not use `wp_redirect()`. Unless there's any reason why it
 should be hooked in `muplugins_loaded`, then it's good to hook it when
 `pluggable.php` is already loaded.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47954#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform