[wp-trac] [WordPress Trac] #47957: Don't verify SSL certificate for loopback test
WordPress Trac
noreply at wordpress.org
Thu Sep 5 14:07:50 UTC 2019
#47957: Don't verify SSL certificate for loopback test
-------------------------+---------------------
Reporter: ocean90 | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.3
Component: Site Health | Version: 5.2
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
-------------------------+---------------------
Comment (by Clorith):
Hmm, we definitely need a more reliable solution overall. The reason the
Site Health check does it this way is because it was copied from how the
plugin/theme editors do them (this was the basis for creating the test, as
a lot of users had issues saving after the changes to t hem were
implemented, all due to loopback failures).
There's now 3 places (likely to be more) that do loopbacks, so having a
fixed loopback function is probably a more sustainable approach?
I'm thinking along the lines of `function loopback( $target_url ) { return
$WP_Http }` which all the places that do loopbacks can use, and by
returning the WP_Http object those places can then check whatever they
need, if that is the content body, headers etc.
This would also be handy for #47954 which looks to do loopback calls to
verify URLs are reachable before breaking a users access to their site.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47957#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list