[wp-trac] [WordPress Trac] #47954: Create a sanity check for siteurl and home changes

[WordPress Trac]

#47954: Create a sanity check for siteurl and home changes
----------------------------+---------------------------------
 Reporter:  Otto42          |       Owner:  (none)
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui, administration
----------------------------+---------------------------------
Changes (by donmhico):

 * keywords:   => has-patch


Comment:

 The attached patch,
 [https://core.trac.wordpress.org/attachment/ticket/47954/47954.diff
 47954.diff], should does the second approach @Otto42 mentioned.
 > Second thought: when these change, email the admin user about them, with
 a revert link that will work no matter what.
 Please feel free to test it so we can further enhance it or fix any bugs
 on it.

 As for
 > Concept: Change the field, make an internal request, see if it fails, if
 so change them back, then warn the user with a "hey, this change seems
 like it's gonna break things real bad, are you really sure?" Or
 equivalent.

 I'll be working on this when time permits.

 I also created a fork branch for this in Github. Again, feel free to help
 out.
 https://github.com/donmhico/wordpress-develop/tree/trac-47954

 @Otto42 @SergeyBiryukov - I'm not sure if this should be `early` for the
 next release but it would be awesome if we can add this to `5.3` milestone
 even just this `email to admin a restore link` that it currently has as
 IMHO, it would really help site admins, especially non-techie ones.
 Thanks.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47954#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform