[wp-trac] [WordPress Trac] #47884: Unable to remove "counts" from non persistent cache groups

WordPress Trac noreply at wordpress.org
Thu Oct 31 16:15:35 UTC 2019


#47884: Unable to remove "counts" from non persistent cache groups
------------------------------+------------------------------
 Reporter:  Maciej Laskowski  |       Owner:  (none)
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Cache API         |     Version:  2.6
 Severity:  normal            |  Resolution:
 Keywords:  close             |     Focuses:  performance
------------------------------+------------------------------

Comment (by boonebgorges):

 > Do you have any opinion on the side note about missing function_exists
 check for wp_cache_add_non_persistent_groups?

 Looking at the `function_exists()` call in [7986], I'm guessing the
 thought was: Any drop-ins existing before [7986] would not have the two
 new functions, but any new drop-ins created afterward presumably would,
 because they'd be created from the up-to-date cache.php. Based on this
 assumption, the single `function_exists()` check is enough, since the
 functions were introduced at the same time. The only way to trigger a
 fatal here would be through an incorrectly built drop-in, and if it hasn't
 cropped up in the past 11 years, I'd say it's not worth guarding against
 now.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47884#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list