[wp-trac] [WordPress Trac] #48472: The "wp_generate_attachment_metadata" filter is not fired when the initial upload request fails but the upload was completed successfully by retrying to create image sub-sizes

WordPress Trac noreply at wordpress.org
Wed Oct 30 19:23:03 UTC 2019


#48472: The "wp_generate_attachment_metadata" filter is not fired when the initial
upload request fails but the upload was completed successfully by retrying
to create image sub-sizes
--------------------------+---------------------
 Reporter:  azaozz        |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.3
Component:  Upload        |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+---------------------

Comment (by azaozz):

 In 48472.diff:
 - Run the `wp_generate_attachment_metadata` filter at the end in
 `wp_update_image_subsizes()` when new metadata was generated and
 additional image sub-sizes were created. This ensures consistent behavior
 with earlier WP versions.
 - Add pass another arg in the `wp_generate_attachment_metadata` filter to
 add context.
 - Fix some inline docs and ensure the new image meta is always saved
 before starting post-processing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48472#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list