[wp-trac] [WordPress Trac] #41870: Code Editor: Add grunt task for building new CodeMirror bundles from external dependencies
WordPress Trac
noreply at wordpress.org
Wed Oct 30 18:31:01 UTC 2019
#41870: Code Editor: Add grunt task for building new CodeMirror bundles from
external dependencies
-------------------------------------------------+-------------------------
Reporter: westonruter | Owner:
| adamsilverstein
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: Future
| Release
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch early needs-testing | Focuses: javascript
needs-refresh |
-------------------------------------------------+-------------------------
Changes (by desrosj):
* keywords: has-patch early needs-testing => has-patch early needs-testing
needs-refresh
Comment:
This came up again with #48456. While this is not a blocker to update
CodeMirror, it's preferable to change over to an automated process to make
this easier going forward.
With that in mind, [attachment:"41870.13.diff"] is an attempt to refresh
against today's `trunk`, but is missing the changes to the Webpack files
(I'm not that familiar with Webpack's innerworkings).
Looking at the changes, I also wonder if adding some of these packages is
necessary since there have been a lot of changes to the build tooling in 2
years.
Some other notes:
- The required PR mentioned above in [ticket:41870#comment:21] has been
merged and released in HTMLhint.
- The current version of CodeMirror is 5.49.2.
- Do we want to use more strict semver versions, or will relying on the
`package-lock.json` file be enough? There is no consistency with this in
the `package.json` file.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41870#comment:51>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list