[wp-trac] [WordPress Trac] #48241: Using `add_theme_support( 'custom-background' )` enables both background color and background image.

WordPress Trac noreply at wordpress.org
Wed Oct 30 08:10:48 UTC 2019


#48241: Using `add_theme_support( 'custom-background' )` enables both background
color and background image.
---------------------------+------------------------------
 Reporter:  williampatton  |       Owner:  (none)
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Themes         |     Version:
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+------------------------------

Comment (by afercia):

 A specific case where this was an issue is Twenty Twenty, where in a first
 time custom background was supported and at the same time the background
 image section in the customizer was removed, see #48338. The initial
 intent was to support only custom background color, but that particular
 set-up led to a clear problem in the core admin menu.

 Seems a legitimate case that theme authors may want to support either a
 custom background image or a custom background color.

 On the related GitHub issue two possible options were mentioned, see
 https://github.com/WordPress/twentytwenty/issues/858#issuecomment-543568847
 - either split the support into 2 separate background support: 1) for
 image and 2) for color
 - or change the "Background Image" customizer section to a generic
 "Background" one, capable to handle both color and / or image

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48241#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list