[wp-trac] [WordPress Trac] #47708: 5.3 about page

[WordPress Trac]

#47708: 5.3 about page
-------------------------------------------------+-------------------------
 Reporter:  karmatosed                           |       Owner:
                                                 |  johnbillion
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.3
Component:  Help/About                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch commit i18n-change dev-    |     Focuses:
  reviewed                                       |  accessibility
-------------------------------------------------+-------------------------

Comment (by ryelle):

 > Looking further at the CSS class name change from .about-wrap to
 `.about__container`. There are currently 243 occurences of "about-wrap"
 found in 37 files (with 47708.12.diff applied). All of these files are
 CSS, there is no about-wrap anywhere in the HTML.

 Right, this new design changes a lot about the page, so the intention was
 to leave the existing CSS in place for a cycle for any plugins that might
 use the about classes in their own pages. We can remove this all in an
 early patch in 5.4, so folks have more time to update.

 It looks like this selector is found in all the files generated from
 `css/about.css`, the color schemes, and an ie-rtl file that I didn't know
 exists and looks like it hasn't been touched since before 4.8.

 > This will possibly bring other "visual regressions", especially if
 plugins add some content on the About screens.

 Aside from the notice, do you know of any plugins that do this? I don't
 think there are any other places _to_ hook in to add content.

 > Thinking the best course of action at this moment is to revert the
 selector name change, then add it "early" during 5.4

 The whole design of the page has changed, reverting the selector would
 only cascade more problems. Let's fix the notice issue, and keep an eye
 out for other issues.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47708#comment:85>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform