[wp-trac] [WordPress Trac] #47708: 5.3 about page

[WordPress Trac]

#47708: 5.3 about page
-------------------------------------------------+-------------------------
 Reporter:  karmatosed                           |       Owner:
                                                 |  johnbillion
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.3
Component:  Help/About                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch commit i18n-change dev-    |     Focuses:
  reviewed                                       |  accessibility
-------------------------------------------------+-------------------------
Changes (by azaozz):

 * keywords:  has-patch commit i18n-change dev-feedback => has-patch commit
     i18n-change dev-reviewed


Comment:

 Looking further at the CSS class name change from `.about-wrap` to
 `.about__container`. There are currently 243 occurences of "about-wrap"
 found in 37 files (with 47708.12.diff applied). All of these files are
 CSS, there is no `about-wrap` anywhere in the HTML.

 This will possibly bring other "visual regressions", especially if plugins
 add some content on the About screens.

 Thinking the best course of action at this moment is to revert the
 selector name change, then add it "early" during 5.4. That will give
 enough time to "clean up" the old CSS and remove or update all selectors,
 and will also give enough time to plugins to make any necessary changes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47708#comment:82>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform