[wp-trac] [WordPress Trac] #48432: WordPress updates broken with proxy and non routed environment

[WordPress Trac]

#48432: WordPress updates broken with proxy and non routed environment
--------------------------+-----------------------------
 Reporter:  sooslaca      |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:  5.2.4
 Severity:  major         |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 Hi,

 This change
 https://core.trac.wordpress.org/changeset/46475/trunk/src/wp-
 includes/http.php

 broke updates when you're using proxy and you don't have DNS
 resolution/routing for the outside world. (like corporate networks)

 Issue came up with this url https://downloads.wordpress.org/plugin
 /multiple-domain.zip

 parsed_url:

 {{{
 Array(
     [scheme] => https
     [host] => downloads.wordpress.org
     [path] => /plugin/multiple-domain.zip
 )
 }}}


 I think it worked before because

 {{{
 if ( empty( $parsed_url['port'] ) ) {
    return $url;
 }
 }}}

 returned the URL and not false.

 I tested changing it back to {{{ $ip = false;}}} and I was able to update
 plugins.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48432>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform