[wp-trac] [WordPress Trac] #31390: Investigate static analysis errors

[WordPress Trac]

#31390: Investigate static analysis errors
--------------------------+-------------------------------
 Reporter:  Caipre        |       Owner:  desrosj
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  coding-standards
--------------------------+-------------------------------
Changes (by desrosj):

 * owner:  wonderboymusic => desrosj
 * focuses:   => coding-standards


Old description:

> I'm the author of hussar, a tool that leverages the static analysis
> functionality of HHVM. I ran the tool against Wordpress master and it
> found ~200 errors. Some of these look like false-positives, but I figured
> I'd let you guys decide.
>
> https://gist.githubusercontent.com/caipre/feb7f9fe46dc2fa90a79/raw/0b0556b65b490b3c7e12f5399dda049d9e71679b/gistfile1.txt
>
> More details about hussar here: https://github.com/wayfair/hussar

New description:

 I'm the author of hussar, a tool that leverages the static analysis
 functionality of HHVM. I ran the tool against WordPress master and it
 found ~200 errors. Some of these look like false-positives, but I figured
 I'd let you guys decide.

 https://gist.githubusercontent.com/caipre/feb7f9fe46dc2fa90a79/raw/0b0556b65b490b3c7e12f5399dda049d9e71679b/gistfile1.txt

 More details about hussar here: https://github.com/wayfair/hussar

--

Comment:

 I'm going to close this out for a few reasons.

 - [https://make.wordpress.org/core/2017/05/25/hhvm-no-longer-part-of-
 wordpress-cores-testing-infrastructure/ Support for HHVM was officially
 removed from WordPress in 2017]. While this doesn't mean someone cannot
 use HHVM to re-run this analysis, I'm willing to bet that the number of
 people who are able and willing to get an HHVM environment running is very
 low (if any). This also makes it difficult for someone to check that the
 issues were fixed.
 - hussar has not received a meaningful update in almost 5 years and seems
 largely abandoned.
 - The [https://github.com/squizlabs/PHP_CodeSniffer PHP_CodeSniffer],
 [WordPress Coding Standards for PHP_CodeSniffer ruleset], and
 [PHPCompatibility/PHPCompatibilityWP PHPCompatibility] rulesets (which are
 much more modern and better maintained) have emerged as the best static
 analysis tools.

 While the results of this analysis were valid at the time, it's highly
 likely a lot of these issues have been fixed or flagged elsewhere. I'm
 going to close as a `wontfix`, but if someone wants to pick this back up
 and run with it, feel free!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/31390#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform