[wp-trac] [WordPress Trac] #47708: 5.3 about page

[WordPress Trac]

#47708: 5.3 about page
----------------------------+----------------------------
 Reporter:  karmatosed      |       Owner:  johnbillion
     Type:  task (blessed)  |      Status:  reviewing
 Priority:  normal          |   Milestone:  5.3
Component:  Help/About      |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:  accessibility
----------------------------+----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:61 afercia]:
 > The headings hierarchy is still not correct and skips one level.
 Basically all the h3 and h4 headings need to be bumped up by one level.
 This was first noted during last week dev chat on Slack.

 Thanks, [attachment:"47708.9.diff"] should fix that.

 Replying to [comment:59 afercia]:
 > Noting that underscores used for the `class` attributes like
 `about__header` etc., are against the WordPress coding standards. They
 should be replaced with hyphens.
 >
 > See https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/css/#selectors
 > > Similar to the WordPress PHP Coding Standards for file names, use
 lowercase and separate words with hyphens when naming selectors. Avoid
 camelcase and underscores.

 I thought comment:51 is a good reasoning for keeping them as is.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47708#comment:62>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform